AvoidRecompilingXPathExpression for Kotlin #295
Conversation
…atAsField' into kotlin/AvoidRecompilingXPathExpression # Conflicts: # src/main/resources/category/kotlin/common.xml
| <priority>2</priority> | ||
| <properties> | ||
| <property name="tag" value="jpinpoint-rule" type="String" description="for-sonar"/> | ||
| <property name="version" value="2.0"/> |
There was a problem hiding this comment.
|
|
||
| class AvoidRecompilingXPathExpressionKotlin { | ||
| fun bad1(doc: Document?): NodeList { | ||
| val xpath: XPath = XPathFactory.newInstance().newXPath() |
There was a problem hiding this comment.
Do we also have a rule to flag use of XPath.newInstance() each time? Also preferred to move to ThreadLocal?
There was a problem hiding this comment.
No we don't have it at the moment. Might be useful.
| <priority>2</priority> | ||
| <properties> | ||
| <property name="tag" value="jpinpoint-rule" type="String" description="for-sonar"/> | ||
| <property name="version" value="2.0"/> |
There was a problem hiding this comment.
also remove version attribute
| } catch (e: XPathExpressionException) { | ||
| throw RuntimeException(e) | ||
| } | ||
| tlExpr = ThreadLocal.withInitial { expr } // good |
There was a problem hiding this comment.
The rule does not check for use in ThreadLocal... probably compile call is only checked in FunctionBody, thus allowed in init block. Is good enough?
There was a problem hiding this comment.
Yes, FunctionBody is used in the rule xpath expression. And I think good enough.
…lingXPathExpression # Conflicts: # docs/EvaluateRulesForKotlin.md # src/main/resources/category/kotlin/common.xml
|
AvoidRecompilingXPathExpression for Kotlin.
Note a code example of the good solution is TODO, the Java example is with ThreadLocals, unclear how this works for Kotlin.