Add Kotlin AvoidRecreatingDateTimeFormatter #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 12, 2024 15:32
|
jborgers
reviewed
Apr 12, 2024
| <value> | ||
| <![CDATA[ | ||
| (: check if java.text imports exists as filter for same named classes in other packages :) | ||
| //ImportHeader[.//T-Identifier[@Text='org'] and .//T-Identifier[@Text='joda'] and .//T-Identifier[@Text='time'] and .//T-Identifier[@Text='format']][1]/ancestor::KotlinFile |
There was a problem hiding this comment.
is this about java.text (1st line) or joda.time (2nd line)?
Should it not hold for both cases? So match on at least one of them?
Include threeten.bp.format? Maybe not, old.
| } | ||
| } | ||
| ]]></code> | ||
| </test-code> |
There was a problem hiding this comment.
Can you add a separate test-code with just java.time import? (no joda.time)
and one without joda.time and without java.time and a custom DateTimeFormatter so without violation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works on basic unit tests.
Should we create more unit tests to avoid false positives and add more Kotlin syntaxes?