Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sqlx to 0.7.1 #33

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: bump sqlx to 0.7.1 #33

wants to merge 2 commits into from

Conversation

Arqu
Copy link

@Arqu Arqu commented Aug 4, 2023

As per #32

@@ -24,13 +24,14 @@ async_std = ["async-std"]
mysql = ["sqlx/mysql", "sqlx/json"]

[dependencies]
async-session = "3.0.0"
sqlx = { version = "0.6.2", features = ["chrono"] }
async-session = { git = "https://github.com/http-rs/async-session", branch = "main"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fairly dangerous.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, on the other hand, there's been no release in over 2 years and some of the deps updates are required for sqlx 0.7.1

async-session = "3.0.0"
sqlx = { version = "0.6.2", features = ["chrono"] }
async-session = { git = "https://github.com/http-rs/async-session", branch = "main"}
sqlx = { version = "0.7.1", features = [ "time" ] }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the logic for switching to time here? That seems unrelated to upgrading.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to async-session moving away from chrono and to time
http-rs/async-session#35

Copy link
Author

@Arqu Arqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this makes sense. Ideally I'd move async-session to a release. Filed http-rs/async-session#63 to nudge things along. Other than that I can just pin it to a commit which is slightly less risky.

@@ -24,13 +24,14 @@ async_std = ["async-std"]
mysql = ["sqlx/mysql", "sqlx/json"]

[dependencies]
async-session = "3.0.0"
sqlx = { version = "0.6.2", features = ["chrono"] }
async-session = { git = "https://github.com/http-rs/async-session", branch = "main"}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, on the other hand, there's been no release in over 2 years and some of the deps updates are required for sqlx 0.7.1

async-session = "3.0.0"
sqlx = { version = "0.6.2", features = ["chrono"] }
async-session = { git = "https://github.com/http-rs/async-session", branch = "main"}
sqlx = { version = "0.7.1", features = [ "time" ] }
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to async-session moving away from chrono and to time
http-rs/async-session#35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants