update types for react 18 #1667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Aug 3, 2022
Closed
benschac
force-pushed
the
add_custom_document_to_next_app
branch
from
2c5e7e9
to
d6a1cfd
Compare
benschac
force-pushed
the
update_types_for_react_18
branch
from
74b2f41
to
8f87468
Compare
benschac
commented
Aug 6, 2022
| @@ -6,6 +6,86 @@ import { NetworkProvider } from 'providers/NetworkProvider' | |||
| import '../styles/antd.css' | |||
| import '../styles/index.scss' | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
My editor shipped with this new thing, https://code.visualstudio.com/updates/v1_69#_3-way-merge-editor.
I thought it resolved conflicts, but I guess not. Will update this PR's conflicts
There was a problem hiding this comment.
Will create a new PR
This was referenced Aug 10, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do and why?
Updates types for React 18 this diff fixes all type errors from types.
Note: I think it makes sense to merge this diff into #1647 so cli will pass.
In order to do so, there were a couple of steps that needed to be taken:
types-react-codemod preset-18 ./srcmore here: https://github.com/eps1lon/types-react-codemod#implicit-children@types/react-reduxit's no longer needed, more here: react-redux installs @types/react@18 reduxjs/react-redux#1898 (comment)Screenshots or screen recordings
If applicable, provide screenshots or screen recordings to demonstrate the changes.
Acceptance checklist