feat(#215): Add several useful constructors for SaxonDocument #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yegor256 Could you have a look, please? |
|
@yegor256 Reminder |
yegor256
reviewed
Jul 21, 2023
| @@ -86,6 +93,56 @@ public SaxonDocument(final String text) { | |||
| this(SaxonDocument.node(text)); | |||
| } | |||
|
|
|||
| /** | |||
| * Public constructor from XML as byte array. | |||
| * @param data XML document body as byte array. | |||
There was a problem hiding this comment.
@volodya-lombrozo it's a good practice to add @since to a method or a class when you introduce it to the code base: https://stackoverflow.com/questions/578363/javadoc-version-and-since
There was a problem hiding this comment.
@yegor256 I've added the "since" tag
volodya-lombrozo
force-pushed
the
215_saxon_constructors
branch
from
5bf467d
to
4f18e89
Compare
|
@yegor256 Could you take a look one more time, please? |
|
@rultor merge |
|
@rultor release, tag is |
|
Job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add several useful constructors for
SaxonDocument.Closes: #215