Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#215): Add several useful constructors for SaxonDocument #216

Merged
merged 4 commits into from
Jul 21, 2023

Conversation

volodya-lombrozo
Copy link
Contributor

Add several useful constructors for SaxonDocument.

Closes: #215

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Could you have a look, please?

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Reminder

@@ -86,6 +93,56 @@ public SaxonDocument(final String text) {
this(SaxonDocument.node(text));
}

/**
* Public constructor from XML as byte array.
* @param data XML document body as byte array.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@volodya-lombrozo it's a good practice to add @since to a method or a class when you introduce it to the code base: https://stackoverflow.com/questions/578363/javadoc-version-and-since

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegor256 I've added the "since" tag

@volodya-lombrozo
Copy link
Contributor Author

@yegor256 Could you take a look one more time, please?

@yegor256
Copy link
Member

@rultor merge

@rultor
Copy link
Contributor

rultor commented Jul 21, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4f18e89 into jcabi:master Jul 21, 2023
8 checks passed
@yegor256
Copy link
Member

@rultor release, tag is 0.29.0

@rultor
Copy link
Contributor

rultor commented Jul 21, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 3min)

@rultor
Copy link
Contributor

rultor commented Jul 21, 2023

@rultor release, tag is 0.29.0

@yegor256 OK, I will release it now. Please check the progress here

@0crat
Copy link

0crat commented Jul 21, 2023

Job gh:jcabi/jcabi-xml#216 is not assigned, can't get performer

@0crat 0crat removed the 0crat/scope label Jul 21, 2023
@rultor
Copy link
Contributor

rultor commented Jul 21, 2023

@rultor release, tag is 0.29.0

@yegor256 Done! FYI, the full log is here (took me 19min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more constructors for SaxonDocument
4 participants