Allow asynchronous callbacks for AsyncRetrying parameters #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mastizada
force-pushed
the
fix-249-async-callback-1
branch
from
13657ee
to
f65ca57
Compare
jd
reviewed
Sep 23, 2022
mastizada
commented
Sep 23, 2022
| return await func(retry_state) | ||
| return func(retry_state) | ||
|
|
||
| async def iter(self, retry_state: "RetryCallState") -> typing.Union[DoAttempt, DoSleep, typing.Any]: # noqa |
There was a problem hiding this comment.
@jd I also wanted to use some base method to avoid re-defining the iter method again, however, one of them is sync def iter and other one is async async def iter. Any ideas how to make it DRY?
I wanted to use handle_custom_function to handle sync/async calls, however, if we make handle_custom_function sync function, then it might need to use asyncio.get_event_loop() to run awaitable functions (running async functions from sync function).
There was a problem hiding this comment.
@jd any ideas? I would love to have a progress with this PR and start using async callbacks for retry_error_callback
This was referenced Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow both async and sync functions to be used as callable parameters for Async retries.
Docs are not updated, please, inform if any other changes are needed. Thank you very much for your review.
Fixes #249