Added CLI wrapper #366
Open
Added CLI wrapper #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
1 similar comment
|
|
jd
requested changes
Mar 2, 2024
| @@ -8,5 +8,6 @@ AUTHORS | |||
| ChangeLog | |||
| .eggs/ | |||
| doc/_build | |||
| venv/ | |||
| @@ -0,0 +1,3 @@ | |||
| #!/usr/bin/env python3 | |||
| from tenacity.__main__ import main | |||
| @@ -18,4 +18,5 @@ | |||
| setuptools.setup( | |||
| setup_requires=["setuptools_scm"], | |||
| use_scm_version=True, | |||
| scripts=["bin/tenacity"], | |||
asqui
reviewed
Mar 2, 2024
| dest="ignore_codes", | ||
| action="append", | ||
| type=int, | ||
| help="Status code that should be ignored. This argument can be called multiple times.", |
There was a problem hiding this comment.
Suggested change
| help="Status code that should be ignored. This argument can be called multiple times.", | |
| help="Non-zero status code that should be ignored. This argument can be called multiple times.", |
|
This seems like a nice feature! Worth mentioning in the release notes, and would be good to have some test coverage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tenacity can now be used as a CLI app to retry shell scripts or apps!
Closes #279
It's not yet complete, some of the advanced functions are left (such as exponential and random wait functions, thinking of a good way to implement those). A changelog is left too, but I wanted your reviews first on whether this is a good change, and if I am following the proper styling/coding guidelines or not.