Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respects min argument for wait_random_exponential #425

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Respects min argument for wait_random_exponential #425

wants to merge 8 commits into from

Conversation

yxtay
Copy link

@yxtay yxtay commented Dec 18, 2023

Summary

Respects min argument for wait_random_exponential

  • currently, min argument only affects computing the high range of the uniform sampling
  • min does not affect the low range of the uniform sampling, hence the sampled wait may be lower than min specified
  • This PR fixes the issue, which I believe is unexpected

Tests

pytest tests/test_tenacity.py::TestWaitConditions::test_wait_random_exponential

jd
jd previously approved these changes Dec 18, 2023
View reviewed changes
@mergify mergify bot dismissed jd’s stale review December 18, 2023 08:41

Pull request has been modified.

@yxtay yxtay requested a review from jd December 18, 2023 08:44
jd
jd previously approved these changes Mar 2, 2024
View reviewed changes
@mergify mergify bot dismissed jd’s stale review March 2, 2024 09:19

Pull request has been modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jd jd jd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yxtay @jd