Add async strategies #451
Add async strategies #451
Conversation
|
|
hasier
force-pushed
the
add-async-strategies-2
branch
from
473c081
to
3c5f788
Compare
tenacity/asyncio/retry.py
Outdated
| def __init__( | ||
| self, predicate: typing.Callable[[typing.Any], typing.Awaitable[bool]] | ||
| ) -> None: | ||
| super().__init__(predicate) # type: ignore[arg-type] |
There was a problem hiding this comment.
Not strictly, but it helps with the typing, otherwise mypy and similar tools would complain about async functions.
There was a problem hiding this comment.
Right, that does not look good though.
I think self.predicate is going to have different types than the one defined in retry_base. I think we might need to not use retry_base or simply use a different async base.
There was a problem hiding this comment.
That's fair. I mainly wanted to keep it dry and reuse as much as possible. Would you rather have a whole new (mainly copy-paste) async implementation for these cases then?
There was a problem hiding this comment.
I think it'd be better. As we started to type everything, I know from experience that trying to be smarter than mypy ends up haunting you at some point.
There was a problem hiding this comment.
hahah fair, done! 927965d
|
@hasier sorry for the long delay, that PR slipped my mind. Don't hesitate to harass me more for reviews. |
|
@jd sorry, I've been busy these last few days, could you take another look at my latest comment? 🙏 |
|
@jd any idea what might be going on with the Tornado tests? https://github.com/jd/tenacity/actions/runs/9347251510/job/25723863307?pr=451 |
|
I think it's #460 |
Third and last PR after breaking down #433 (follows
hasier#1#437)Support async actions hasier/tenacity#1Support async actions #437After DRYing the
iter()function and makingAsyncRetryingsupportasynccallbacks, add newasyncstrategies (basically a copy-paste) and improve typing.Supersedes hasier#2