Jdbi JPMS (java module) support #2470
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the only thing I can really say is you should define a proper module-info file and have moditect pick it up(much easier to read than XML). see this |
hgschmie
force-pushed
the
jpms
branch
2 times, most recently
from
b16ba23
to
7568e56
Compare
- MJAVADOC-767 (javadoc) - plexus-java problem (compiler)
must contain fix for SUREFIRE-2190 (see https://github.com/hgschmie/msurefire2190)
we really need to switch to spotless
add an automatic module id to the test jars, so test jar and main jar can coexist on the module path.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS NOT FOR THE FAINT OF HEART
Add full JPMS module support using the moditect jpms tooling.
Adds an integration test suite that integration-tests all generated jars using their
own unit tests.
This is at best lightly tested and probably requires a lot of additional works
Please test. good luck. ;-)
See also #2453 / @SentryMan