Make build work on java 22-ea #2569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revisit the mockito setup (this can be improved once mockito/mockito#3137 has landed and was released with mockito). For now, we add the bytebuddy agent directly. Also update spotbugs and junit, which is needed to pass build under Java 22-ea.
hgschmie
force-pushed
the
mockito-revisited
branch
from
baf828d
to
8ea8d5f
Compare
|
stevenschlansker
approved these changes
Jan 2, 2024
|
Fixes #2549 |
|
I have spent a bit more time looking into this, and I think we can avoid needing bytebuddy agent at all (and therefore avoid needing to do all the pom dance here to bring it in for 22-ea). See #2593 |
|
I'll close this for now since we have 22-ea working without the agent altogether. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revisit the mockito setup (this can be improved once
mockito/mockito#3137 has landed and was
released with mockito). For now, we add the bytebuddy agent directly.
Also update spotbugs and junit, which is needed to pass build under
Java 22-ea.