Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oralce12 module moved back #2664

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

oralce12 module moved back #2664

wants to merge 6 commits into from

Conversation

stoyants
Copy link
Contributor

Closes #2660

@stoyants
Copy link
Contributor Author

I see there is a problem with the new module - "japicmp" plugin can't find version 3.45.1 , which is the most recent "jdbi" tag
But this is because "jdb2-oracle12" seems not to be tagged at the same time with main "jdbi" repo.
And even when I try to create the version for me locally "japicmp" complains now about version "3.45.0", because even such tag exists, maybe it was not build or pushed to maven central. The latest version there is "3.44.1"

I'm trying to sort out this for me locally.

Best regards, Stoyan

Copy link

sonarcloud bot commented Mar 24, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stevenschlansker
Copy link
Member

Thank you for contributing this! @hgschmie , do you have a sec to look into the japicmp problems? Or maybe this is something we can just ignore and will be fixed after we make a release.

Copy link
Member

@stevenschlansker stevenschlansker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I guess we will merge this and see what happens after we make a release.

@stevenschlansker
Copy link
Member

Actually, I am going to try to backdate a release jar for the new artifact and see if the job will pick that up.

@stevenschlansker
Copy link
Member

I tried to get the build working today.
I got as far as the container not becoming ready. The logs show:

Session altered.

   CREATE USER test IDENTIFIED BY "test" QUOTA UNLIMITED ON USERS
*
ERROR at line 1:
ORA-01109: database not open

I didn't figure out how to fix this. I tried updating to latest testcontainers version with no change.

@stoyants
Copy link
Contributor Author

stoyants commented May 7, 2024

Hi @stevenschlansker

I merged some commit, which came after my changes, in the "oracle12" branch and pushed to the MR. This started a new build (as my plan was).

And yes, I see the same message there: https://github.com/jdbi/jdbi/actions/runs/8990130231/job/24694783402?pr=2664

CREATE USER test IDENTIFIED BY "test" QUOTA UNLIMITED ON USERS
*
ERROR at line 1:
ORA-01109: database not open

No idea at the moment why GitHub pipeline fails so miserably.
I know, that it sounds pathetic, but I tested on2 different computers (one native Linux and one WSL) ... all runs fine.
I will have a look again. And I don't think it is related to the Java code. I suspect it is setup / environment related.

Best Regards, Stoyan

@stoyants
Copy link
Contributor Author

stoyants commented May 8, 2024

Hi @stevenschlansker,

Seems the pipeline is trying to run all 4 oracle test classes in parallel. But this creates 4 docker testcontainers at the same time.
This is slow, in fact they interfere with each other. I extended the start-up timeout to 10 minutes (only to test). And ... it run out of disk space (have a look in the last build logs)

./23_Test Oracle versions (21-slim-faststart).txt:2024-05-08T20:28:32.0430409Z ##[warning]You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 45 MB
::::
./24_Test Oracle versions (18-slim-faststart).txt:2024-05-08T20:29:00.6337597Z ##[warning]You are running out of disk space. The runner will stop working when the machine runs out of disk space. Free space left: 33 MB

I will check how to request from the pipeline to run the tests sequentially.

Best Regards,
Stoyan

Copy link

sonarcloud bot commented May 12, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stoyants
Copy link
Contributor Author

Hi @stevenschlansker ,
Can you please re-start the workflow? I fixed the problem with oracle12 testcontainers, but it failed again. And I see no relation between the problems and my changes.
Best regards, Stoyan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Move Oracle artifact back into main build
2 participants