Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix current implementation of get and getAll #1

Closed
wants to merge 2 commits into from
Closed

Fix current implementation of get and getAll #1

wants to merge 2 commits into from

Conversation

yordis
Copy link

@yordis yordis commented Oct 17, 2018 •
edited

@jdeniau hey mate, could you take this so we use your PR for finish the spec for get and getAll

@jdeniau jdeniau changed the base branch from master to jd-feat-getAndGetAll October 17, 2018 10:26
@jdeniau
Copy link
Owner

jdeniau commented Oct 17, 2018

Oh I updated form-data#388 from your comments as well. I think it's the same code, I just used filter instead of reduce

@yordis
Copy link
Author

yordis commented Oct 17, 2018

@jdeniau but the reason I used reduce is that you avoid doing two loops over the same dataset. That is why reduce is useful in this case.

@yordis yordis closed this Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yordis @jdeniau