Use "--omit=dev" internally on newer npm version #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the behaviour when the `--production` flag is used on the CLI of this project to, instead of just using '--production', do: 1. get the version of npm being used, 2. check the version against a version range, 3. use '--production' for older npm version, or 4. use '--omit=dev' for newer npm version. Two notes regarding point 2: 1. The version range is probably incorrect as is. I based it on the GitHub issue with the idea to either let it evolve over time as reports come in, or adjust it after this commit if it's preferred that the range is (likely) correct before this is released. 2. To perform the version range check I added a new runtime dependency, namely "semver". See: https://www.npmjs.com/package/semver Lastly, while I updated the tests, the tests as they are now are not ood. The current test suite assumes you're running them with a newer version of npm. It would be better if the tests are somehow run with a controlled version of npm instead, or better yet, with various versions of npm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
Update the behaviour when the
--productionflag is used on the CLI of this project to, instead of just using--productionwhen invokingnpm audit, do:Note that this change is not a breaking change for this project.
While I updated the tests, the tests as they are now are not ood. The current test suite assumes you're running them with a newer version of npm. It would be better if the tests are somehow run with a controlled version of npm instead, or better yet, with various versions of npm.
Footnotes
The version range is probably incorrect as is. I based it on the GitHub issue with the idea to either let it evolve over time as reports come in, or adjust it after this commit if it's preferred that the range is (likely) correct before this is released. ↩
To perform the version range check I added a new runtime dependency, namely "semver". See: https://www.npmjs.com/package/semver ↩