Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust color contrast to comply with WCAG 2.0 AA #500

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adjust color contrast to comply with WCAG 2.0 AA #500

wants to merge 3 commits into from

Conversation

mgifford
Copy link

These new colors address color contrast issues in the default theme. These new colors meet WCAG 2.0 AA.

@mgifford mgifford mentioned this pull request Mar 29, 2020
Closed
@ashmaroli
Copy link
Member

Thank you for submitting this pull request @mgifford.
Could you post a couple of screenshots showcasing the before scenario and after scenario..?

Also, I'd prefer having lowercase characters for the colors' hex values...

@ashmaroli
Copy link
Member

@mgifford We're considering a migration to use data files to render the social icons in #451. So you may want to defer changes to the social icon include until a decision is made on that PR.

@mgifford
Copy link
Author

@ashmaroli If you are revisiting the social media icons, just make sure that they have accessibility plugged in. SVG files need titles, or if they are decorative need to be clearly hidden.

I don't know how to do what you are asking for. I wanted to have 2 separate pull requests. No idea why they got merged together. Couldn't find an easy way to submit a new one.

Not sure how to "defer changes to the social icons" so at the moment I'll leave them as is.

jyhi added a commit to jyhi/www that referenced this pull request Jul 29, 2021
@jyhi
_config.yml: change skin back to classic
bc2306a 
jekyll/minima#500 only effects on the classic theme. It's now
recommended to use browsers' reader views instead of forcing the
solarized skin.
mattr-
mattr- reviewed Dec 29, 2021
View reviewed changes
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate you updating things to WCAG 2.0 AA. Would you be able to provide before and after screenshots and fix that small typo I found?

_includes/social.html Outdated Show resolved Hide resolved
@ashmaroli ashmaroli changed the title adjusting color contrast Adjust color contrast to comply with WCAG 2.0 AA Dec 31, 2021
@ashmaroli
Copy link
Member

@mgifford There seems to be a merge conflict due to recent changes to the master branch.
Will you be able to rebase your branch onto latest master?

Additionally, I prefer having the new hex values being in lowercase to be consistent with existing values.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattr- mattr- mattr- left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
pending-rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mgifford @ashmaroli @mattr-