refactor: minor syntax improvements

* Update defineEmits to Vue 3.3 "labeled tuple elements" syntax * Fix minor type error * Simplify nested ternary operation
jellyfin · Aug 16, 2023 · 2cd4542 · 2cd4542
1 parent 3990010
commit 2cd4542
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 9 deletions.
diff --git a/frontend/src/components/Dialogs/GenericDialog.vue b/frontend/src/components/Dialogs/GenericDialog.vue
@@ -54,7 +54,7 @@ const props = defineProps<{
 }>();
 
 const emit = defineEmits<{
-  (e: 'close'): void;
+  close: [];
 }>();
 
 const slots = useSlots();

diff --git a/frontend/src/components/Item/ItemMenu.vue b/frontend/src/components/Item/ItemMenu.vue
@@ -324,13 +324,12 @@ const copyDownloadURLAction = {
       /**
        * The Map is mapped to an string like: EpisodeName: DownloadUrl
        */
-      const text = streamUrls
-        ? typeof streamUrls === 'string'
-          ? streamUrls
-          : [...streamUrls.entries()]
+      const text =
+        streamUrls instanceof Map
+          ? [...streamUrls.entries()]
               .map(([k, v]) => `(${k}) - ${v}`)
               .join('\n')
-        : undefined;
+          : streamUrls;
 
       const copyAction = async (txt: string): Promise<void> => {
         await clipboard.copy(txt);

diff --git a/frontend/src/components/Item/MediaDetail/MediaDetailDialog.vue b/frontend/src/components/Item/MediaDetail/MediaDetailDialog.vue
@@ -145,7 +145,7 @@ import { getLocaleName } from '@/utils/i18n';
 const props = defineProps<{ item: BaseItemDto; mediaSourceIndex?: number }>();
 
 const emit = defineEmits<{
-  (e: 'close'): void;
+  close: [];
 }>();
 
 const { t, locale } = useI18n();

diff --git a/frontend/src/components/Item/MediaSourceSelector.vue b/frontend/src/components/Item/MediaSourceSelector.vue
@@ -27,7 +27,7 @@ const selectProps = defineProps<{
 }>();
 
 const emits = defineEmits<{
-  (e: 'input', newIndex: number): void;
+  input: [newIndex: number];
 }>();
 
 const currentSource = ref(

diff --git a/frontend/src/components/Playback/MusicVisualizer.vue b/frontend/src/components/Playback/MusicVisualizer.vue
@@ -33,7 +33,6 @@ onBeforeUnmount(() => {
   if (visualizerInstance) {
     visualizerInstance.disconnectInput();
     visualizerInstance.disconnectOutput();
-    visualizerInstance = undefined;
   }
 });
 </script>