Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin lockfile in .npmrc #1633

Merged
merged 2 commits into from Dec 13, 2021
Merged

Pin lockfile in .npmrc #1633

merged 2 commits into from Dec 13, 2021

Conversation

ferferga
Copy link
Member

This is an attempt to fix dependabot updates messing with the lockfile version 3.

Right now, npm 8 will generate an v2 lockfile if an user wants to regen their lockfile or issues an npm i --package-lock-only. In order to match this repo's v3, the --lockfile-version 3 argument must be used. This PR adds that config to .npmrc file, essentially fixing this for everybody transparently, without the need to add any additional CLI arguments.

Also, I bumped the minimum npm and nodejs version, as npm 8.1.0 had an issue where numbers where treated as strings, which was fixed in npm 8.1.2 (which is included in nodejs 16.13.1)

@jellyfin-bot jellyfin-bot added this to In progress in Ongoing development Dec 13, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #1633 (b324d2b) into master (1b9e7da) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1633   +/-   ##
=======================================
  Coverage   53.46%   53.46%           
=======================================
  Files          24       24           
  Lines         881      881           
  Branches      155      155           
=======================================
  Hits          471      471           
  Misses        402      402           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b9e7da...b324d2b. Read the comment docs.

Ongoing development automation moved this from In progress to Reviewer approved Dec 13, 2021
@ThibaultNocchi ThibaultNocchi merged commit 80d759c into master Dec 13, 2021
Ongoing development automation moved this from Reviewer approved to Done Dec 13, 2021
@ThibaultNocchi ThibaultNocchi deleted the pin-lockfile branch December 13, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants