Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove workaround for Safari's iOS fullscreen #1906

Merged
merged 2 commits into from
Mar 29, 2023
Merged

fix: remove workaround for Safari's iOS fullscreen #1906

merged 2 commits into from
Mar 29, 2023

Conversation

ferferga
Copy link
Member

@jellyfin-bot jellyfin-bot added the vue Pull requests that edit or add Vue files label Mar 22, 2023
@jellyfin-bot jellyfin-bot added this to In progress in Ongoing development Mar 22, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeQL.yml:analyze. As part of the setup process, we have scanned this repository and found 3 existing alerts. Please check the repository Security tab to see all alerts.

@jellyfin-bot jellyfin-bot added the merge conflict Something has merge conflicts label Mar 22, 2023
@ferferga ferferga force-pushed the remove-fullscreen-workaround branch from afdc2e1 to 4df3b0c Compare March 22, 2023 18:17
@jellyfin-bot jellyfin-bot removed the merge conflict Something has merge conflicts label Mar 22, 2023
@ferferga ferferga force-pushed the remove-fullscreen-workaround branch 6 times, most recently from df217a6 to bf182aa Compare March 28, 2023 09:29
@ferferga ferferga force-pushed the remove-fullscreen-workaround branch from bf182aa to 2bd0caf Compare March 28, 2023 11:44
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit ac67989
Status ✅ Deployed!
Preview URL https://35cf06fc.jf-vue.pages.dev
Type 🔀 Preview

View build logs
View bot logs

ThibaultNocchi
ThibaultNocchi approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@ThibaultNocchi ThibaultNocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and iPad ✅

Ongoing development automation moved this from In progress to Reviewer approved Mar 29, 2023
@ThibaultNocchi ThibaultNocchi merged commit ed94249 into vite Mar 29, 2023
Ongoing development automation moved this from Reviewer approved to Done Mar 29, 2023
@ThibaultNocchi ThibaultNocchi deleted the remove-fullscreen-workaround branch March 29, 2023 21:06
@ferferga ferferga added this to the Vue 3 milestone Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThibaultNocchi ThibaultNocchi ThibaultNocchi approved these changes

Assignees
No one assigned
Labels
vue Pull requests that edit or add Vue files
Projects
Ongoing development
Done
Milestone
Vue 3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferferga @jellyfin-bot @ThibaultNocchi