Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing context menu items #1951

Closed
wants to merge 30 commits into from

Conversation

noaione
Copy link
Contributor

@noaione noaione commented Apr 13, 2023

Implemented almost every context menu item that are missing from JF-Vue

Added the following item:

  • Refresh metadata (on anything other than Library)
  • Media Info
  • Copy Stream URL
  • Download single/all
  • Delete media
  • Instant mix
  • Identify

And maybe implement this:

Also Fix #1950

I didn't know that much Vue so any feedback is appreciated.

@jellyfin-bot jellyfin-bot added the vue Pull requests that edit or add Vue files label Apr 13, 2023
@jellyfin-bot jellyfin-bot added this to In progress in Ongoing development Apr 13, 2023
Removed the fallback clipboard copy code since it looks like the whole project is targeting es2022.

Also cleanup/restructure some i18n strings
…ri app

Added the following packages:
- tauri-apps/api
- tauri_plugin_upload (handle stream download)

Both clipboard and file download should now use their respective native API.
Clipboard use either the navigator or tauri clipboard API
File download use the <a> download trick or use the downloader from tauri_plugin_upload
since using stream download would be better so it does not eat memory.

Added a new task to handle file download announcement (Tauri only)
Maybe add a way to announce error to the task manager.
Also cleaned up old legacy code for file download.
@jellyfin-bot jellyfin-bot added the merge conflict Something has merge conflicts label Apr 14, 2023
@jellyfin-bot jellyfin-bot removed the merge conflict Something has merge conflicts label Apr 14, 2023
@noaione noaione marked this pull request as ready for review April 15, 2023 15:35
@noaione
Copy link
Contributor Author

noaione commented Apr 16, 2023

Closing since the PR has been split into a "smaller" one

PR 1: #1962 (Copy/Download/Media Info)
PR 2: #1963 (Refresh metadata)
PR 3: #1964 (Delete item)
PR 4: #1965 (Instant mix)
PR 5: #1966 (Identify)
PR 6: Blocked by other PR 1-5 (Add multiple streams support)

@noaione noaione closed this Apr 16, 2023
Ongoing development automation moved this from In progress to Done Apr 16, 2023
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 23, 2023
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 23, 2023
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 23, 2023
Split from: jellyfin#1951

Ignore the lint error since the Refresh metadata PR should fix it.
ferferga pushed a commit to noaione/jellyfin-vue that referenced this pull request Apr 27, 2023
* Split from: jellyfin#1951
* Also add CanDelete to API requests
ferferga pushed a commit that referenced this pull request Apr 27, 2023
* Split from: #1951
* Also add CanDelete to API requests
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 28, 2023
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 28, 2023
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 28, 2023
ferferga pushed a commit to noaione/jellyfin-vue that referenced this pull request Apr 28, 2023
ferferga pushed a commit to noaione/jellyfin-vue that referenced this pull request Apr 28, 2023
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 28, 2023
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 29, 2023
Split from: jellyfin#1951

fix: invalid i18n key hiding the Identify action

feat: add `ExternalUrls` fields to userLibraries store

This should be able to show the prefilled data on the home screen now
noaione added a commit to noaione/jellyfin-vue that referenced this pull request Apr 29, 2023
noaione added a commit to noaione/jellyfin-vue that referenced this pull request May 3, 2023
ferferga pushed a commit that referenced this pull request May 4, 2023
Split from: #1951

fix: invalid i18n key hiding the Identify action

feat: add `ExternalUrls` fields to userLibraries store

This should be able to show the prefilled data on the home screen now
noaione added a commit to noaione/jellyfin-vue that referenced this pull request May 5, 2023
ferferga pushed a commit to noaione/jellyfin-vue that referenced this pull request Jun 20, 2023
ferferga pushed a commit to noaione/jellyfin-vue that referenced this pull request Aug 15, 2023
ferferga pushed a commit to noaione/jellyfin-vue that referenced this pull request Aug 16, 2023
ferferga pushed a commit that referenced this pull request Aug 16, 2023
@noaione noaione deleted the feat/more-context-menu branch August 17, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vue Pull requests that edit or add Vue files
Projects
Development

Successfully merging this pull request may close these issues.

Song item detected as MusicAlbum instead of Audio in Context Menu
3 participants