Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Media Info, Download, and Copy Stream URL to context menu #1962

Merged
merged 6 commits into from Aug 16, 2023
Merged

feat: add Media Info, Download, and Copy Stream URL to context menu #1962

merged 6 commits into from Aug 16, 2023

Commits on Aug 16, 2023

  1. feat: add Media Info, download, and copy to context menu 

    Split from the following PR: jellyfin#1951
    @noaione @ferferga
    noaione authored and ferferga committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4d30978 View commit details
    Browse the repository at this point in the history

  2. refactor: adjust how media info looked 

    - Also generalize the modal dialog for both media info and identify.
- Removed copy code for mediainfo
- Use single content component for all media stream type

Right now, it's using normal Yes/No for boolean with i18n translation key since it would be easier to copy the text.
    @noaione @ferferga
    noaione authored and ferferga committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a2854c1 View commit details
    Browse the repository at this point in the history

  3. refactor: requested changes on mediainfo 

    * Remove `Is AVC` field: It's useless, the user can already check the 'Codec' property
* Refactor component population using loops
* General info of an element is always visible, not under tags
    @ferferga
    ferferga committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4884d1c View commit details
    Browse the repository at this point in the history

  4. refactor: minor refactors 

    * watch ref directly on MediaSourceSeelector
* Use useClipboard composable
    @ferferga
    ferferga committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    4e2c5b0 View commit details
    Browse the repository at this point in the history

  5. refactor: address review comments about downloads 

    Given initiating a download is browser-specific and we already have the "Copy stream URL"
option, we can just leave it alone and let the user fire downloads manually
to avoid extra browser shenanigans and checks
    @ferferga
    ferferga committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    3990010 View commit details
    Browse the repository at this point in the history

  6. refactor: minor syntax improvements 

    * Update defineEmits to Vue 3.3 "labeled tuple elements" syntax
* Fix minor type error
* Simplify nested ternary operation
    @ferferga
    ferferga committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2cd4542 View commit details
    Browse the repository at this point in the history