Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syncplay playback starting before listener created #5518

Merged
merged 1 commit into from
May 15, 2024

Conversation

thornbill
Copy link
Member

Changes
Fixes syncplay playback starting before listener created

Issues
Fixes #5485

@thornbill thornbill requested a review from a team as a code owner May 15, 2024 22:24
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 703ec1b
Status ✅ Deployed!
Preview URL https://5ac93b6c.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill added bug Something isn't working regression We broke something stable backport Backport into the next stable release labels May 15, 2024
@thornbill thornbill added this to the v10.9.2 milestone May 15, 2024
@thornbill thornbill added this to In progress in Release 10.9.z via automation May 15, 2024
Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested it, but this change was tested in the linked issue, and it looks sane to me.

@thornbill thornbill merged commit 25b1bca into jellyfin:release-10.9.z May 15, 2024
10 checks passed
Release 10.9.z automation moved this from In progress to Done May 15, 2024
@thornbill thornbill deleted the fix-syncplay-crash branch May 15, 2024 23:45
joshuaboniface pushed a commit that referenced this pull request May 17, 2024
Fix syncplay playback starting before listener created

Original-merge: 25b1bca

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants