Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strictly check for Node 16 LTS and lockfile v3 #145

Merged
merged 3 commits into from Sep 6, 2022
Merged

Strictly check for Node 16 LTS and lockfile v3 #145

merged 3 commits into from Sep 6, 2022

Conversation

ferferga
Copy link
Member

@ferferga ferferga commented Sep 6, 2022 •
edited

  • Enforces the engine checks to enforce the current LTS version (16 at the time of writing). The minimum version check of 16.3.1 and npm 8.1.2 is to ensure that users has an npm version that doesn't have problems when installing dependencies using the v3 lockfile (see fix: allow --lockfile-version config to be string and coerce to number npm/cli#3949). Node 16.3.1 was the earliest node version to include the npm update with the fix.
  • Upgrades to the v3 lockfile format.

@ferferga
Strictly check for LTS versions in engines
3e4f215 
* Also enforces a minimum version of 16.13.1 to avoid issues with lockfile v3: npm/cli#3949
@ferferga
Update to lockfile v3 format
477e17c
@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Sep 6, 2022
@thornbill thornbill merged commit 65bcb50 into master Sep 6, 2022
@thornbill thornbill deleted the v3-lockfile branch September 6, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ferferga @thornbill