New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling #11103
base: master
Are you sure you want to change the base?
Fix spelling #11103
Conversation
Changes in OpenAPI specification found. Expand to see details.What's Changed
|
@@ -1263,7 +1263,7 @@ internal ItemImageInfo ItemImageInfoFromValueString(ReadOnlySpan<char> value) | |||
/// <param name="id">The id.</param> | |||
/// <returns>BaseItem.</returns> | |||
/// <exception cref="ArgumentNullException"><paramref name="id"/> is <c>null</c>.</exception> | |||
/// <exception cref="ArgumentException"><paramr name="id"/> is <seealso cref="Guid.Empty"/>.</exception> | |||
/// <exception cref="ArgumentException"><paramref name="id"/> is <seealso cref="Guid.Empty"/>.</exception> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain about this, but there wasn't any strong hint justifying the divergence..
@@ -90,7 +90,7 @@ public async Task ExecuteAsync(IProgress<double> progress, CancellationToken can | |||
} | |||
catch (OperationCanceledException) | |||
{ | |||
// InstallPackage has it's own inner cancellation token, so only throw this if it's ours | |||
// InstallPackage has its own inner cancellation token, so only throw this if it's ours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's
= it is
which is not intended here
@@ -46,7 +46,7 @@ public CreateUserLoggingConfigFile(IApplicationPaths appPaths) | |||
public Guid Id => Guid.Parse("{EF103419-8451-40D8-9F34-D1A8E93A1679}"); | |||
|
|||
/// <inheritdoc/> | |||
public string Name => "CreateLoggingConfigHeirarchy"; | |||
public string Name => "CreateLoggingConfigHierarchy"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change might be observable
@@ -319,7 +319,7 @@ private void PopulateBackdrops(BaseItem item, List<LocalImageInfo> images, List< | |||
{ | |||
AddImage(files, images, name + "-fanart", ImageType.Backdrop, imagePrefix); | |||
|
|||
// Support without the prefix if it's in it's own folder | |||
// Support without the prefix if it's in its own folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here it is
is appropriate in the first instance, but not in the second
debian/conf/jellyfin
Outdated
JELLYFIN_ARGS="$JELLYFIN_WEB_OPT $JELLYFIN_FFMPEG_OPT $JELLYFIN_SERVICE_OPT $JELLYFIN_NOWEBAPP_OPT $JELLFIN_ADDITIONAL_OPTS --datadir $JELLYFIN_DATA_DIR --configdir $JELLYFIN_CONFIG_DIR --logdir $JELLYFIN_LOG_DIR --cachedir $JELLYFIN_CACHE_DIR" | ||
JELLYFIN_ARGS="$JELLYFIN_WEB_OPT $JELLYFIN_FFMPEG_OPT $JELLYFIN_SERVICE_OPT $JELLYFIN_NOWEBAPP_OPT $JELLYFIN_ADDITIONAL_OPTS --datadir $JELLYFIN_DATA_DIR --configdir $JELLYFIN_CONFIG_DIR --logdir $JELLYFIN_LOG_DIR --cachedir $JELLYFIN_CACHE_DIR" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no comment justifying this typo, so I'm assuming it's just a typo. Note that this will impact anyone who has specifically defined this variable.
"description": "This plugin will track all media changes while any Infuse clients are offline to decrease sync times when logging back in to your server.", | ||
"description": "This plugin will track all media changes while any Infuse clients are offline to decrease sync times when logging back into your server.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change tends to be controversial. -- I'm happy to drop any particular changes.
Some people argue that log in
is a specific thing. I personally believe that log
is the verb and that this into
isn't special.
public async Task GetRootFolder_NonExistenUserId_NotFound() | ||
public async Task GetRootFolder_NonexistentUserId_NotFound() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
existent
was misspelled here (and in other instances below).
Note that nonexistent is a word in its own right which is appropriate in these cases which is why I'm selecting it -- but if you'd rather a smaller change that only added a t
as required, I can provide that instead.
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Please squash your commits to avoid commit spam. |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* altogether * artist * bandwidth * cannot * case-insensitive * case-sensitive * configuration * delimiter * dependent * diacritics * directors * enable * environment * explicitly * extends * external * finish * hierarchy * implicit * into * its * keepalive * language * localization * macos * manual * matching * metadata * nonexistent * options * overridden * paramref * parser * playback * preferring * processes * processing * provider * ratings * reassemble * seconds * separate * should * station * subdirectories * superseded * supported * system * than * the * throws * transcoding * valid * was Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
Changes
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/jellyfin/actions/runs/8136096545#summary-22231815791
The action will report that the changes in this PR would make it happy: https://github.com/jsoref/jellyfin/actions/runs/8136096761#summary-22231816255
Issues