Skip to content

Commit

Permalink
cleanup(get.jenkins.io): remove long-lived SAS token and related outp…
Browse files Browse the repository at this point in the history
…uts (#654)

This PR removes `mirrorbits` file share long-lived SAS token and related
outputs, replaced by the use of a storage key stored in jenkins-infra
hieradata & charts-secrets.

Verification procedure after merging this PR: ensure update_center job
still passes on trusted.ci.jenkins.io (file share used in sync.sh &
sync-recent-releases.sh scripts)

Ref:
-
jenkins-infra/helpdesk#3414 (comment)
  • Loading branch information
lemeurherve committed Apr 4, 2024
1 parent 751ac5d commit 1f0274f
Showing 1 changed file with 0 additions and 44 deletions.
44 changes: 0 additions & 44 deletions get.jenkins.io.tf
Original file line number Diff line number Diff line change
Expand Up @@ -49,47 +49,3 @@ resource "azurerm_storage_share" "get_jenkins_io_website" {
storage_account_name = azurerm_storage_account.get_jenkins_io.name
quota = 100 # Minimal size, 1.6GiB used in 2020
}

data "azurerm_storage_account_sas" "get_jenkins_io" {
connection_string = azurerm_storage_account.get_jenkins_io.primary_connection_string
signed_version = "2022-11-02"

resource_types {
service = true # Ex: list Share
container = true # Ex: list Files and Directories
object = true # Ex: create File
}

services {
blob = false
queue = false
table = false
file = true
}

start = "2024-01-25T00:00:00Z"
expiry = "2024-04-25T00:00:00Z"

# https://learn.microsoft.com/en-us/rest/api/storageservices/create-account-sas#file-service
permissions {
read = true
write = true
delete = true
list = true
add = false
create = true
update = false
process = false
tag = false
filter = false
}
}

output "get_jenkins_io_share_url" {
value = azurerm_storage_share.get_jenkins_io.url
}

output "get_jenkins_io_sas_query_string" {
sensitive = true
value = data.azurerm_storage_account_sas.get_jenkins_io.sas
}

0 comments on commit 1f0274f

Please sign in to comment.