Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add trusted_ci_jenkins_io_fileshare_serviceprincipal_writer outputs #558

Merged
merged 2 commits into from
Dec 20, 2023
Merged

chore: add trusted_ci_jenkins_io_fileshare_serviceprincipal_writer outputs #558

merged 2 commits into from
Dec 20, 2023

Conversation

lemeurherve
Copy link
Member

@lemeurherve lemeurherve commented Dec 20, 2023 •
edited

@lemeurherve lemeurherve marked this pull request as ready for review December 20, 2023 13:53
@lemeurherve lemeurherve requested a review from a team as a code owner December 20, 2023 13:53
lemeurherve
lemeurherve commented Dec 20, 2023
View reviewed changes
trusted.ci.jenkins.io.tf Outdated Show resolved Hide resolved
smerle33
smerle33 approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@smerle33 smerle33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lemeurherve
Copy link
Member Author

Changes to Outputs:

  • trusted_ci_jenkins_io_fileshare_serviceprincipal_writer_id = "f7813dae-xxxx-xx-xx-350aff8e00b7"
  • trusted_ci_jenkins_io_fileshare_serviceprincipal_writer_password = (sensitive value)

You can apply this plan to save these new output values to the Terraform
state, without changing any real infrastructure.

@lemeurherve lemeurherve merged commit 1b9b1ae into jenkins-infra:main Dec 20, 2023
7 checks passed
@lemeurherve lemeurherve deleted the follow-up-fileshare-sp-writer-outputs branch December 20, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

@smerle33 smerle33 smerle33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lemeurherve @dduportal @smerle33