-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pkg) add 'mirrorbrain' user back under puppet management #3357
Merged
dduportal
merged 4 commits into
jenkins-infra:production
from
dduportal:feat/pkg/mirrorbrain-user
Mar 29, 2024
Merged
feat(pkg) add 'mirrorbrain' user back under puppet management #3357
dduportal
merged 4 commits into
jenkins-infra:production
from
dduportal:feat/pkg/mirrorbrain-user
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Puppet agent disabled on the |
lemeurherve
previously approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Co-authored-by: Hervé Le Meur <91831478+lemeurherve@users.noreply.github.com>
lemeurherve
previously approved these changes
Mar 28, 2024
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Deployment result:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to jenkins-infra/helpdesk#3414 (comment)
This PR fixes #3351 by putting back the
mirrorbrain
user under puppet management and also manages the.azure-storage-env
with the current values from resources managed in https://github.com/jenkins-infra/azure/blob/main/get.jenkins.io.tf.Added resources comes from #2185.
Tested locally with vagrant but of course there could be a configuration shift with production: before merging, the puppet agent on
pkg
VM must be disabled and stopped. Once merged, apuppet
noop command is needed to compare the expected changes (and avoid breaking the current setup which is manually managed).Note that a manual cleanup is required after this PR is applied. The following files will have to be removed:
/srv/releases/.ssh/gruenehoelle_mirror*
(ref. Mirror-decommission: mirror.gruenehoelle.nl helpdesk#3281)/srv/releases/.ssh/mirrorbits-staging*
(not used anywhere)