chore(pkg) templatize mirror-scripts on the 'pkgrepo' profile #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The set of "mirror scripts" imported in jenkins-infra#3358 have their content templatized to map to puppet hieradata configuration used by profiles. Note: the profile `updatesite` has been updated (default param. value move to hieradata) to allow other profiles to lookup the value (`updatesite` and `pkgrepo`` are still highly coupled on the same VM). Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
dduportal
force-pushed
the
chore/pkg/templatize-mirror-scripts
branch
from
96bed4d
to
81d4bad
Compare
smerle33
reviewed
Mar 29, 2024
smerle33
reviewed
Mar 29, 2024
smerle33
reviewed
Mar 29, 2024
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
smerle33
reviewed
Mar 29, 2024
|
Deployed with success during a pairing session with @smerle33 (hence the self-merged suggestions). We confirmed that the scripts are running properly (as per the described procedure). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #3358 (and will need rebase before complete review or only check the last commit)
Follow up of jenkins-infra/helpdesk#3414
This PR is the second step of #3352 (after #3358).
It introduces the following changes:
Note: the profile
updatesitehas been updated (default param. value move to hieradata) to allow other profiles to lookup the value (updatesiteandpkgrepo) are still highly coupled on the same VM).Deployment process:
sync.sh(like the crontab) and validate full execution (~2 min)