Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce font-size of navbar and download button #116

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

krisstern
Copy link
Member

@krisstern krisstern commented Dec 6, 2023

  1. Decreased the font-size of navbar and download button from 0.875rem to 0.8rem so it would not collapse to two rows when small laptop screen size is slightly reduced.
  2. Set "Jenkins" tag to redirect to "https://www.jenkins.io/".
  3. Update wording of buttons from "Success Stories" to "Stories" and "Contributor Spotlight" to "Contributors".

c.c. @lemeurherve @alyssat @jmMeessen @gounthar @MarkEWaite

@halkeye
Copy link
Member

halkeye commented Dec 6, 2023

thats a lot of changes for "reduce font"

@halkeye
Copy link
Member

halkeye commented Dec 6, 2023

Aka please revert unrelated changes

If you want to change quote style make sure there's linting rules to enforce it and it's in its own pr do we can easily see what changed in this one.

@krisstern krisstern force-pushed the feat/adjust-font-size-to-optimise-header-ui-ux branch from fa384d3 to 1e83f66 Compare December 7, 2023 00:14
@krisstern
Copy link
Member Author

Hi @halkeye,
My apologies for the changes coming from Prettier formatting! I have removed these so this PR can be more easily reviewed. Can we keep the change in the <a> redirection address though as this has been discussed during a recent Advocacy and Outreach SIG meeting before if I remember correctly?

@krisstern
Copy link
Member Author

thats a lot of changes for "reduce font"

I have changed the font size to 0.825rem so as not to reduce too much.

@krisstern
Copy link
Member Author

Also, made a change in wording for the buttons for "Success Stories" and "Contributor Spotlight" as suggested by @MarkEWaite.

src/jio-navbar.ts Outdated Show resolved Hide resolved
@halkeye
Copy link
Member

halkeye commented Dec 7, 2023

image

I'm finding the font surprisingly a lot smaller. I'm not against it, but it feels like a big change and should get more eyes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants