Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add CONTRIBUTING.md to follow Conventional Commits #141

Merged
merged 2 commits into from
May 24, 2024

Conversation

nouralmulhem
Copy link
Contributor

@nouralmulhem nouralmulhem commented Mar 15, 2024

this PR addressing issue#105

this is a proposed contribution guide that we can refer to in the README to insure consistency

@nouralmulhem nouralmulhem changed the title Add CONTRIBUTING.md to follow Conventional Commits docs: Add CONTRIBUTING.md to follow Conventional Commits Mar 15, 2024
@nouralmulhem
Copy link
Contributor Author

@daniel-beck @halkeye would be great if you can provide your thoughts

Copy link
Member

@halkeye halkeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its so much better than what we have \o/

@halkeye halkeye merged commit 650135f into jenkins-infra:main May 24, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants