-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
broken link fix for 'helm chart' at 'Private artifacts' table #6724
broken link fix for 'helm chart' at 'Private artifacts' table #6724
Conversation
add 'maintainers guidelines' to README.adoc
proposed logo for this repository
I have fixed the conflicts, next time I will create seperate branch that is fresh sync taken from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for detecting the broken link. In this case, it is best if we remove the row rather than misleading readers to think that there is such a thing as https://repo.private.jenkins.io
As far as I can tell, that entry was added in 2020 and was removed as an unused chart in 2021 (commit 7f6f7891c7476a968cfb894c0e8fc334e083661e in the helm charts repository).
Could you delete that line instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed as suggested
That's very good to see that you're detecting and working to resolve those types of issues. Some of the steps you might consider taking on your local repository include: # Add upstream repository if not already added
git remote add upstream https://github.com/jenkins-infra/jenkins.io.git
git fetch --all
# Checkout the master branch
git checkout master
# Make your local copy of the master branch match the upstream master
git reset --hard upstream/master
# Make your forked master branch match the upstream master branch
git push origin --force master Those instructions assume that your repository includes a remote named "origin" and that the remote "origin" is your fork. You're welcome to ignore those suggestions as well. No shame learning command git in whatever way works best for you. |
PR part of issue [#3335]
On analyzing jenkins.io/projects/infrastructure/ I found a broken-link as per below
The link highlighted in red given the following on click
I have fixed the link through this PR which will now direct to the below screen