Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken link fix for 'helm chart' at 'Private artifacts' table #6724

Merged
merged 13 commits into from
Sep 30, 2023

Conversation

abhishekmaity
Copy link
Contributor

PR part of issue [#3335]
On analyzing jenkins.io/projects/infrastructure/ I found a broken-link as per below

Screenshot 2023-09-30 202112
The link highlighted in red given the following on click

Screenshot 2023-09-30 202441
I have fixed the link through this PR which will now direct to the below screen

Screenshot 2023-09-30 203644

@abhishekmaity abhishekmaity requested a review from a team as a code owner September 30, 2023 15:09
@abhishekmaity
Copy link
Contributor Author

I have fixed the conflicts, next time I will create seperate branch that is fresh sync taken from jenkins-infra:master rather than branched-out from abhishekmaity:master

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for detecting the broken link. In this case, it is best if we remove the row rather than misleading readers to think that there is such a thing as https://repo.private.jenkins.io

As far as I can tell, that entry was added in 2020 and was removed as an unused chart in 2021 (commit 7f6f7891c7476a968cfb894c0e8fc334e083661e in the helm charts repository).

Could you delete that line instead?

Copy link
Contributor Author

@abhishekmaity abhishekmaity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed as suggested

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Sep 30, 2023

I have fixed the conflicts, next time I will create seperate branch that is fresh sync taken from jenkins-infra:master rather than branched-out from abhishekmaity:master

That's very good to see that you're detecting and working to resolve those types of issues. Some of the steps you might consider taking on your local repository include:

# Add upstream repository if not already added
git remote add upstream https://github.com/jenkins-infra/jenkins.io.git
git fetch --all
# Checkout the master branch
git checkout master
# Make your local copy of the master branch match the upstream master
git reset --hard upstream/master
# Make your forked master branch match the upstream master branch
git push origin --force master

Those instructions assume that your repository includes a remote named "origin" and that the remote "origin" is your fork. You're welcome to ignore those suggestions as well. No shame learning command git in whatever way works best for you.

@MarkEWaite MarkEWaite enabled auto-merge (squash) September 30, 2023 16:10
@MarkEWaite MarkEWaite merged commit 491767b into jenkins-infra:master Sep 30, 2023
6 of 9 checks passed
@abhishekmaity abhishekmaity deleted the broken-link-1 branch September 30, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants