Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jcasc: Fix Gitter broken format of JCasC on projects page #7113

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

tungbq
Copy link
Contributor

@tungbq tungbq commented Feb 21, 2024

This PR is to fix Gitter broken format of JCasC on projects page. Might related to #3335

Page URL: https://www.jenkins.io/projects/jcasc/#time-and-location

Current format was broken:
image

Resolution:

@tungbq tungbq requested a review from a team as a code owner February 21, 2024 14:08
@tungbq tungbq changed the title Fix Gitter broken format of JCasC on projects page jcasc: Fix Gitter broken format of JCasC on projects page Feb 21, 2024
Copy link
Contributor

@kmartens27 kmartens27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and from my local test it does appear to resolve the link display issue.

Thanks very much @tungbq!!

@MarkEWaite MarkEWaite merged commit f64c88c into jenkins-infra:master Feb 21, 2024
5 checks passed
@tungbq tungbq deleted the jcasc-broken-format branch February 21, 2024 15:22
@tungbq
Copy link
Contributor Author

tungbq commented Feb 21, 2024

This looks good, and from my local test it does appear to resolve the link display issue.

Thanks very much @tungbq!!

Thanks @kmartens27 for your review and feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants