Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Download page paragraphs #7168

Merged
merged 2 commits into from Mar 9, 2024
Merged

Fix Download page paragraphs #7168

merged 2 commits into from Mar 9, 2024

Conversation

7adidaz
Copy link
Contributor

@7adidaz 7adidaz commented Mar 8, 2024 •
edited

Fix the misaligned paragraphs in #7158

Before:
image

After:
image

@7adidaz 7adidaz requested a review from a team as a code owner March 8, 2024 18:46
@MarkEWaite
Copy link
Contributor

Thanks for the pull request. Please include a "before" and "after" screenshot so that the changes are clearly visible in the pull request description.

Please also describe any other testing that was done to confirm that the change did not have unintended side effects.

@7adidaz
Copy link
Contributor Author

7adidaz commented Mar 8, 2024

Thanks for the pull request. Please include a "before" and "after" screenshot so that the changes are clearly visible in the pull request description.

I updated the PR's description

Please also describe any other testing that was done to confirm that the change did not have unintended side effects.

I didn't, since the CSS added was embedded in the haml file, the changes will only apply to this page.

NotMyFault
NotMyFault approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@NotMyFault NotMyFault requested a review from a team March 9, 2024 12:58
MarkEWaite
MarkEWaite approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@MarkEWaite MarkEWaite merged commit f19009e into jenkins-infra:master Mar 9, 2024
6 checks passed
@MarkEWaite MarkEWaite mentioned this pull request Mar 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@7adidaz @MarkEWaite @NotMyFault