Set homepage as plugins.jenkins.io for new plugins and update defaults #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Brandes <mc.cache@web.de>
Signed-off-by: Alexander Brandes <mc.cache@web.de>
NotMyFault
changed the title
Signed-off-by: Alexander Brandes <mc.cache@web.de>
NotMyFault
commented
Mar 3, 2024
src/main/java/io/jenkins/infra/repository_permissions_updater/hosting/Hoster.java
Outdated
Show resolved
Hide resolved
Comment on lines
+256
to
+258
| if (!r.getDefaultBranch().equals("main")) { | ||
| r.setDefaultBranch("main"); | ||
| } |
There was a problem hiding this comment.
GitHub recommends creating new repositories with main over master, and it's the selected default if you do that through GitHub.
I'd like to build upon that and ensure we don't introduce new degenerative terms.
NotMyFault
commented
Mar 3, 2024
src/main/java/io/jenkins/infra/repository_permissions_updater/hosting/Hoster.java
Outdated
Show resolved
Hide resolved
…hosting/Hoster.java
timja
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3573