Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Developers List #3823

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

Simplify3x
Copy link
Contributor

@Simplify3x Simplify3x commented Mar 18, 2024

Link to GitHub repository

https://github.com/jenkinsci/simplifyqa-pipeline-executor

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @Simplify3x
  • @bernardbdas

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist Release permission checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to accounts.jenkins.io.
    Options
  2. All users added have logged in to Artifactory and Jira once.
    Options
  3. I have mentioned an existing team member of the plugin or component team to approve this request.
    Options

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Link to the PR enabling CD in your plugin

CD checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist CD checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. I have provided a link to the pull request in my plugin, which enables CD according to the documentation.
    Options

Reviewer checklist

Edit tasklist title
Beta Give feedback Tasklist Reviewer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Check that the $pluginId Developers team has Admin permissions while granting the access.
    Options
  2. In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
    Options
  3. If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.
    Options

There are IRC Bot commands for it.

@Simplify3x Simplify3x requested a review from a team as a code owner March 18, 2024 12:28
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the name and coordinates post hosting is undesired. Revert the change

@Simplify3x
Copy link
Contributor Author

Changing the name and coordinates post hosting is undesired. Revert the change

Is there any way we can modify the name of the repository or release paths?

@NotMyFault
Copy link
Member

NotMyFault commented Mar 18, 2024

Given this creates an hpi you can't update from, we don't do that. If you want to release a new major version with breaking changes, I recommend setting the hpi.compatibleSinceVersion property in your pom, see https://www.jenkins.io/doc/developer/plugin-development/mark-a-plugin-incompatible/

@Simplify3x Simplify3x changed the title Update Release Path, Repo name and add user Update Developers List Mar 19, 2024
@Simplify3x
Copy link
Contributor Author

Reverted back

@Simplify3x Simplify3x closed this Mar 19, 2024
@Simplify3x Simplify3x reopened this Mar 19, 2024
@Simplify3x
Copy link
Contributor Author

Hi
We have enabled cd and the build at https://ci.jenkins.io/job/Plugins/job/simplify-qa-connector-plugin/job/main/ is also passing, yet there is no release getting pushed onto the Jenkins marketplace or via github actions.

Can anyone from Jenkins team assist us with this query?

@NotMyFault
Copy link
Member

There's no PR merged with an interesting label CD would pick up.

Keep in mind to log in with the account added to artifactory and jira in order to move this PR on.

@NotMyFault NotMyFault added the needs initial login The users need to log in to Jira and/or Artifactory label Mar 20, 2024
@NotMyFault
Copy link
Member

In order to move this request forward, the user added must log in to Jira and artifactory first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs initial login The users need to log in to Jira and/or Artifactory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants