Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin-libvirt-slave: Add new developer #3825

Merged
merged 1 commit into from Mar 18, 2024

Conversation

bgermann
Copy link
Contributor

@bgermann bgermann commented Mar 18, 2024

Link to GitHub repository

Libvirt Agents

When modifying release permission

List the GitHub usernames of the users who should have commit permissions below:

  • @mjeanson

This is needed in order to cut releases of the plugin or component.

If you are modifying the release permission of your plugin or component, fill out the following checklist:

Release permission checklist (for submitters)

Edit tasklist title
Beta Give feedback Tasklist Release permission checklist (for submitters), more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The usernames of the users added to the "developers" section in the .yml file are the same the users use to log in to accounts.jenkins.io.
    Options
  2. All users added have logged in to Artifactory and Jira once.
    Options
  3. I am an existing team member of the plugin team and approve this request.
    Options

When enabling automated releases (cd: true)

Follow the documentation to ensure, your pull request is set up properly. Don't merge it yet.
In case of changes requested by the hosting team, an open PR facilitates future reviews, without derailing work across multiple PRs.

Reviewer checklist

Edit tasklist title
Beta Give feedback Tasklist Reviewer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Check that the $pluginId Developers team has Admin permissions while granting the access.
    Options
  2. In the case of plugin adoption, ensure that the Jenkins Jira default assignee is either removed or changed to the new maintainer.
    Options
  3. If security contacts are changed (this includes add/remove), ping the security officer (currently @Wadeck) in this pull request. If an email contact is changed, wait for approval from the security officer.
    Options

There are IRC Bot commands for it.

@bgermann bgermann requested a review from a team as a code owner March 18, 2024 18:35
@NotMyFault NotMyFault added the needs initial login The users need to log in to Jira and/or Artifactory label Mar 18, 2024
@bgermann bgermann closed this Mar 18, 2024
@bgermann bgermann reopened this Mar 18, 2024
@NotMyFault NotMyFault enabled auto-merge (squash) March 18, 2024 20:36
@NotMyFault NotMyFault added authorization OK and removed needs initial login The users need to log in to Jira and/or Artifactory labels Mar 18, 2024
@NotMyFault NotMyFault merged commit ede98a7 into jenkins-infra:master Mar 18, 2024
3 checks passed
@bgermann bgermann deleted the libvirt-slave branch March 18, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants