Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository URL of mock plugin #3827

Closed

Conversation

NotMyFault
Copy link
Member

cc @jglick as a maintainer, what do you think? This would match with the other slave -> agent repos.

Signed-off-by: Alexander Brandes <mc.cache@web.de>
@NotMyFault NotMyFault requested a review from a team as a code owner March 18, 2024 20:46
@jglick
Copy link
Contributor

jglick commented Mar 18, 2024

Would make

<gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>

not be accurate; to avoid confusion I prefer to have the repo name align with the artifactId. The display name and description have already been updated so this seems unnecessary.

@NotMyFault
Copy link
Member Author

No strong objections either way. I just thought it would align better with the other renamed repositories.

@jglick
Copy link
Contributor

jglick commented Mar 21, 2024

…which are kind of a mess, because now we have https://github.com/jenkinsci/ssh-agent-plugin (plugin name ssh-agent) which runs the ssh-agent tool (an actual agent), and https://github.com/jenkinsci/ssh-agents-plugin (plugin name ssh-slaves) which runs slaves agents over SSH.

No strong opinion either, just a general preference to keep repo URLs aligned with artifactIds which must be stable.

@NotMyFault NotMyFault closed this Mar 21, 2024
@NotMyFault NotMyFault deleted the update-mock-slave branch March 21, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants