feat: add storage module
#131
Conversation
lemeurherve
force-pushed
the
helpdesk3414-sp-for-file-shares
branch
from
b76f9d3
to
28bfdfc
Compare
Opened jenkins-infra/azure#557 |
There was a problem hiding this comment.
This is really a nice job!
I've provided a few suggestion, with one blocker.
Additionally, how do you feel about renaming the module to underline its intent?
I would expect azure-jenkinsinfra-storage to create the file storage for me while it only sets up an Azure SP and its permissions to write to this filestorage.
WDYT about azure-jenkinsinfra-storage-serviceprincipal-writer?
| type = string | ||
| } | ||
|
|
||
| variable "storage_service_principal_ids" { |
There was a problem hiding this comment.
See my comment in https://github.com/jenkins-infra/azure/pull/557/files#r1431730896 which underline the poor naming I did on the controller module.
WDYT about the following name in this case to make it easier to understand?
| variable "storage_service_principal_ids" { | |
| variable "storage_active_directory_application_owners" { |
There was a problem hiding this comment.
I've removed "application" from this variable name as it's for the owner of the service principal too, not only the app.
|
Merging to continue, will do another PR if names need more adjustments. |
This PR uses jenkins-infra/shared-tools#131 to allow trusted.ci.jenkins.io to manipulate the File Share content of updates.jenkins.io Ref: - jenkins-infra/helpdesk#3414 (comment)
This PR adds a module to create a service principal to manipulate Azure File Shares.
Ref:
blobxferbyazcopyhelpdesk#3414 (comment)