Enable script-security tests again (#1463)

jenkinsci · Jan 4, 2024 · 1846668 · 1846668
1 parent 9b1dee9
commit 1846668
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 7 deletions.
diff --git a/src/test/java/plugins/GroovyPluginTest.java b/src/test/java/plugins/GroovyPluginTest.java
@@ -35,7 +35,6 @@
 import org.jenkinsci.test.acceptance.po.Build;
 import org.jenkinsci.test.acceptance.po.FreeStyleJob;
 import org.jenkinsci.test.acceptance.po.ToolInstallation;
-import org.junit.Ignore;
 import org.junit.Test;
 
 @WithPlugins("groovy")
@@ -76,7 +75,6 @@ public void run_system_groovy() {
     }
 
     @Test
-    @Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
     public void run_system_groovy_from_file() {
         configureJob();
 

diff --git a/src/test/java/plugins/JobDslPluginTest.java b/src/test/java/plugins/JobDslPluginTest.java
@@ -37,7 +37,6 @@
 import org.jenkinsci.test.acceptance.po.View;
 import org.jenkinsci.test.acceptance.update_center.PluginSpec;
 import org.jenkinsci.test.acceptance.utils.IOUtil;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebElement;
@@ -655,7 +654,6 @@ public void should_use_grooy_sandbox_whitelisted_content() {
      * 'Manage Jenkins' area. Approved scripts can be executed.
      */
     @Test @WithPlugins({"matrix-auth@2.3","mock-security-realm","authorize-project"})
-    @Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
     public void should_use_grooy_sandbox_no_whitelisted_content() {
         GlobalSecurityConfig sc = setUpSecurity();
         runBuildAsUserWhoTriggered(sc);

diff --git a/src/test/java/plugins/ScriptSecurityPluginTest.java b/src/test/java/plugins/ScriptSecurityPluginTest.java
@@ -35,7 +35,6 @@
 import org.jenkinsci.test.acceptance.po.Job;
 import org.jenkinsci.test.acceptance.po.WorkflowJob;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 
 @WithPlugins({"script-security", "matrix-auth"})
@@ -116,7 +115,6 @@ public void scriptNeedsApproval() throws Exception {
 
     @Test
     @WithPlugins("groovy-postbuild")
-    @Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
     public void signatureNeedsApproval() throws Exception {
         final FreeStyleJob job = createFailedJobWithGroovyPostBuild("def h = java.lang.System.getProperties()", true);
         login(ADMIN);
@@ -143,7 +141,6 @@ public void pipelineNeedsApproval() throws Exception {
 
     @Test
     @WithPlugins({"workflow-job","workflow-cps"})
-    @Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
     public void pipelineSignatureNeedsApproval() throws Exception {
         final WorkflowJob job = createFailedPipeline("def h = java.lang.System.getProperty('java.version')", true);
         login(ADMIN);