Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing PR 7569 - Command Palette #1103

Closed
wants to merge 12 commits into from
Closed

Testing PR 7569 - Command Palette #1103

wants to merge 12 commits into from

Conversation

janfaracik
Copy link
Contributor

@janfaracik
Copy link
Contributor Author

Heya @basil! Total novice here when it comes to this sort of stuff, how would I update the PR to test https://ci.jenkins.io/job/Core/job/jenkins/job/PR-7569/? Thanks

@basil
Copy link
Member

basil commented Apr 6, 2023

@janfaracik Wait until you get a passing CI build of your core PR that ends with this:

[Pipeline] stage
[Pipeline] { (Deploy)
[Pipeline] withCredentials
Masking supported pattern matches of $FUNCTION_TOKEN
[Pipeline] {
[Pipeline] httpRequest
HttpMethod: POST
URL: https://incrementals.jenkins.io/
Content-Type: application/json
Authorization: *****
Sending request to url: https://incrementals.jenkins.io/
Response Code: HTTP/1.1 200 OK
Response: 
Response from Artifactory: OK
Success: Status code 200 is in the accepted range: 100:599
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] }
[Pipeline] // stage

Then in your core PR go to the Checks tab, Jenkins Incrementals Publisher, Incrementals, View more details on Jenkins Incrementals Publisher. Note the incremental version and then update this PR with e.g.

diff --git a/pom.xml b/pom.xml
index f5304c69..054efc7e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -31,7 +31,8 @@
     <changelist>999999-SNAPSHOT</changelist>
     <spotbugs.skip>true</spotbugs.skip>
 
-    <jenkins.version>2.399</jenkins.version>
+    <!-- TODO https://github.com/jenkinsci/jenkins/pull/7569 -->
+    <jenkins.version>2.400-rc33526.0fb_9f1f080df</jenkins.version>
     <selenium.version>4.8.1</selenium.version>
     <guava.version>31.1-jre</guava.version> <!-- aligned with selenium -->
     <aether.version>1.1.0</aether.version>

@jtnord jtnord marked this pull request as draft June 5, 2023 14:37
@jtnord
Copy link
Member

jtnord commented Jun 5, 2023

converted to draft as this is not somethign we want to merge - and the test suite runs the same under a draft as non draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants