Attempt to fix gitlab tests flakiness #1425
Draft
+192
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I detected most of the times flakiness was caused by a lack of resources in the Gitlab container, as a result many API calls at random returned a 502 error code and an HTML page asking for the user to refresh... I have added a custom configuration to the Gitlab fixture which should help in resource constrained environments and increased the request timeout. Also not it uses the readiness checks instead of html web scrapping. Also some small code changes here and there like closing the gitlab4j clients or slighly reduce the scope of some tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I detected most of the times flakiness was caused by a lack of resources in the Gitlab
container, as a result many API calls at random returned a 502 error code
and an HTML page asking for the user to refresh...
I have added a custom configuration to the Gitlab fixture which should help in
resource constrained environments and increased the request timeout. Also
not it uses the readiness checks instead of html web scrapping.
Also some small code changes here and there like closing the gitlab4j clients
or slighly reduce the scope of some tests.
Testing done
More than 50 local runs once I got rid of flakiness, also some runs in CloudBees proprietary builders, I also plan to have several runs on this PR builder before moving out of draft status
Submitter checklist