Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable script-security tests again #1463

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Enable script-security tests again #1463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e577ec3
Enable `script-security` tests again
jglick Jan 3, 2024
0d7ddb9
Merge branch 'master' into script-security
jglick Jan 3, 2024
3d08d8e
Merge branch 'master' into script-security
jglick Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/test/java/plugins/GroovyPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.jenkinsci.test.acceptance.po.Build;
import org.jenkinsci.test.acceptance.po.FreeStyleJob;
import org.jenkinsci.test.acceptance.po.ToolInstallation;
import org.junit.Ignore;
import org.junit.Test;

@WithPlugins("groovy")
Expand Down Expand Up @@ -76,7 +75,6 @@ public void run_system_groovy() {
}

@Test
@Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
public void run_system_groovy_from_file() {
configureJob();

Expand Down
2 changes: 0 additions & 2 deletions src/test/java/plugins/JobDslPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
import org.jenkinsci.test.acceptance.po.View;
import org.jenkinsci.test.acceptance.update_center.PluginSpec;
import org.jenkinsci.test.acceptance.utils.IOUtil;
import org.junit.Ignore;
import org.junit.Test;
import org.openqa.selenium.By;
import org.openqa.selenium.WebElement;
Expand Down Expand Up @@ -655,7 +654,6 @@ public void should_use_grooy_sandbox_whitelisted_content() {
* 'Manage Jenkins' area. Approved scripts can be executed.
*/
@Test @WithPlugins({"matrix-auth@2.3","mock-security-realm","authorize-project"})
@Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
public void should_use_grooy_sandbox_no_whitelisted_content() {
GlobalSecurityConfig sc = setUpSecurity();
runBuildAsUserWhoTriggered(sc);
Expand Down
3 changes: 0 additions & 3 deletions src/test/java/plugins/ScriptSecurityPluginTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import org.jenkinsci.test.acceptance.po.Job;
import org.jenkinsci.test.acceptance.po.WorkflowJob;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;

@WithPlugins({"script-security", "matrix-auth"})
Expand Down Expand Up @@ -116,7 +115,6 @@ public void scriptNeedsApproval() throws Exception {

@Test
@WithPlugins("groovy-postbuild")
@Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
public void signatureNeedsApproval() throws Exception {
final FreeStyleJob job = createFailedJobWithGroovyPostBuild("def h = java.lang.System.getProperties()", true);
login(ADMIN);
Expand All @@ -143,7 +141,6 @@ public void pipelineNeedsApproval() throws Exception {

@Test
@WithPlugins({"workflow-job","workflow-cps"})
@Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1444")
public void pipelineSignatureNeedsApproval() throws Exception {
final WorkflowJob job = createFailedPipeline("def h = java.lang.System.getProperty('java.version')", true);
login(ADMIN);
Expand Down