Upgrade tests to use JUnit5

[strangelookingnerd]

It should be considered best practice to start plugin development using JUnit5 over JUnit4.

• org.junit.* imports being updated to JUnit5 equivalents
• Use @WithJenkins in combination with JenkinsRule
• Make test classes and methods package-private (convention for JUnit5)

I'm not 100% convinced that I migrated SampleConfigurationTest correctly since I was not able to find a proper equivalent for JenkinsSessionRule - maybe @basil could confirm if the test still covers the intended functionality.

Testing done

Ran mvn clean verify without errors.

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. Link to relevant pull requests, esp. upstream and downstream changes

   Link to relevant pull requests, esp. upstream and downstream changes
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
6. Ensure you have provided tests - that demonstrates feature works or fixes the issue

   Ensure you have provided tests - that demonstrates feature works or fixes the issue
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

[basil]

I put some print statements in the evaluate() methods and didn't see them getting executed, so I don't think multiple Jenkins sessions (with the same Jenkins home directory) are working in JUnit 5 yet, at least not in the manner demonstrated in this PR. My preference would be for us to get that working first before we start to recommend JUnit 5 project-wide. Otherwise we would be recommending a replacement that has fewer features than the original.

[strangelookingnerd]

@basil Thanks for checking. I will look into it and try to find a proper solution. I was a little put off by the assertion stating "still there after restart of Jenkins" but now I know what’s supposed to happen.

[basil]

I do not feel comfortable yet recommending this as a general pattern in the archetype because it involves copying and pasting this code into every plugin that wants to use this feature with JUnit 5. The existing JUnit 4 functionality is generalized and easy-to-use, and I think its JUnit 5 equivalent should be equally generalized and easy-to-use without copying and pasting code like this into every Jenkins plugin.

[strangelookingnerd]

100% agree on that, should have converted to draft. I was just looking for a solution that works at all. There are quite some roadblocks ahead to make JUnit5 work nicely with the current JenkinsRule implementation.