Support changing session token environment variable name #74
+56
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the status on this? Having the env hardcoded seems like a bug. If two credentials are referenced, wouldn't they both set the same env? |
|
@alecharp Do you know if this plugin is still active? |
|
I do not maintain this plugin. |
|
@csssuf This change looks good to me, however there are conflicts to resolve. |
Vlatombe
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #39, rebased on current master and updated to include feedback from the original PR.
I didn't update the copyright statement, as mentioned in the original PR - I believe the file still does need some copyright statement, but I wasn't sure what to change it to, so I left it as-is.
I also wasn't sure if the
@DataBoundConstructorannotation should go on the new constructor with the additional argument, or the old constructor, but I've put it on the new one here. Let me know if that needs to be changed!