Use new dialog design for adding credentials

[zbynek]

Uses a nicer dialog (no need to scroll to get OK button, works with dark theme, ...), reducing dependency on YUI framework.

Testing done

Checked that credentials can be added (username and password) when running hpi:run

Screenshot

Submitter checklist

Edit tasklist title

Beta Give feedback Tasklist Submitter checklist, more options

• Rename
• Copy markdown
• Delete tasklist

Delete tasklist

Delete tasklist block?

Are you sure? All relationships in this tasklist will be removed.

Cancel Delete

1. Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!

   Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
2. Ensure that the pull request title represents the desired changelog entry

   Ensure that the pull request title represents the desired changelog entry
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
3. Please describe what you did

   Please describe what you did
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
4. Link to relevant issues in GitHub or Jira

   Link to relevant issues in GitHub or Jira
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove
5. No tests - frontend change only

   No tests - frontend change only
   Options

   • Convert to issue
   • Toggle completion
   • Rename
   • Remove

Add item to Submitter checklist

[timja]

nice! (not tested locally, code and screenshots look good)

[NotMyFault]

Looks good in mvn hpi:run :)

[zbynek]

@jtnord will you have time to review/merge this?

[mawinter69]

I think it would be better to have the Add Credentials in the title as well
e.g. Add Credentials (Provider: Jenkins)

[zbynek]

Good idea, but I'd suggest to do that in a follow-up PR and keep this one just about the design.

[timja]

@zbynek looks like some tests are failing

[zbynek]

Should be passing now. The main issue was that HtmlUnit got updated and the tests ran into HtmlUnit/htmlunit#740

[timja]

@jglick possible to merge please?

[timja]

@jglick addressed review comment

[jglick]

@zbynek @timja I think this broke ATH. For example https://ci.jenkins.io/job/Core/job/acceptance-test-harness/job/master/1063/testReport/plugins/SshSlavesPluginTest/lts_linux_jdk11_firefox_split8___connectWithPassword/

org.openqa.selenium.NoSuchElementException: Unable to locate By.cssSelector: #credentialsDialog in http://127.0.0.1:38331/computer/createItem
	at org.jenkinsci.test.acceptance.po.CapybaraPortingLayerImpl.find(CapybaraPortingLayerImpl.java:197)
	at org.jenkinsci.test.acceptance.plugins.credentials.Credential.add(Credential.java:30)
	at org.jenkinsci.test.acceptance.plugins.ssh_slaves.SshSlaveLauncher.pwdCredentials(SshSlaveLauncher.java:76)
	at plugins.SshSlavesPluginTest.connectWithPassword(SshSlavesPluginTest.java:165)

[zbynek]

@jglick thanks for pointing that out, fixed in jenkinsci/acceptance-test-harness#1497.