Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mockito-inline from tests #1440

Merged
merged 2 commits into from Apr 17, 2023
Merged

Remove mockito-inline from tests #1440

merged 2 commits into from Apr 17, 2023

Conversation

MarkEWaite
Copy link
Contributor

Remove mockito-inline from tests

https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.60 notes that mockito-inline was removed in mockito/mockito#2945, replaced with mockito-core.

Checklist

  • I have read the CONTRIBUTING doc
  • I have referenced the Jira issue related to my changes in one or more commit messages
  • I have added tests that verify my changes
  • Unit tests pass locally with my changes
  • I have added documentation as necessary
  • No Javadoc warnings were introduced with my changes
  • No spotbugs warnings were introduced with my changes
  • Documentation in README has been updated as necessary
  • Online help has been added and reviewed for any new or modified fields
  • I have interactively tested my changes
  • Any dependent changes have been merged and published in upstream modules (like git-client-plugin)

Types of changes

  • Test

@github-actions github-actions bot added dependencies Dependency related change and removed test labels Apr 17, 2023
@MarkEWaite MarkEWaite added test and removed dependencies Dependency related change labels Apr 17, 2023
@MarkEWaite MarkEWaite enabled auto-merge (squash) April 17, 2023 20:51
@MarkEWaite MarkEWaite enabled auto-merge (squash) April 17, 2023 20:52
@MarkEWaite
Use parent pom 4.60
e5d4f16 
mockito-inline was removed in mockito/mockito#2945, replaced with
mockito-core. Consumers of mockito-inline should replace their dependency
on mockito-inline with a dependency on mockito-core.
@github-actions github-actions bot added dependencies Dependency related change and removed test labels Apr 17, 2023
@MarkEWaite MarkEWaite merged commit 1dff7b6 into jenkinsci:master Apr 17, 2023
14 checks passed
@MarkEWaite MarkEWaite deleted the replace-mockito-inline-with-core branch April 22, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Dependency related change
Projects
None yet
Milestone
No milestone
1 participant
@MarkEWaite