Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBSITE-634] - Add Release Drafter configuration for drafting Weekly release YAMLs #4097

Merged
merged 2 commits into from
Jul 18, 2019

Conversation

oleg-nenashev
Copy link
Member

@oleg-nenashev oleg-nenashev commented Jul 3, 2019

This is a follow-up to the common issues with delayed weekly release changelogs. Neither @daniel-beck nor me commit to deliver changelogs on the weekends when Jenkins weekly gets usually released, and often there are significant delays between a release and availability of changelog on https://jenkins.io/changelog/ . In order to solve the issue, I suggest using Release Drafter which has been already successfully adopted in plugins (Documentation). See WEBSITE-634 for more context.

Sample changelog YAML generated in my test environment:

ReleaseDrafter_YAML

Considerations:

Proposed changelog entries

Submitter checklist

  • JIRA issue is well described
  • Changelog entry appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    * Use the Internal: prefix if the change has no user-visible impact (API, test frameworks, etc.)
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Wishlist

  • Type resolution
  • Sorting by categories: rfe, then bug and then internal
  • Putting Major fixes on the top

Desired reviewers

@jenkinsci/core esp. @daniel-beck

@oleg-nenashev oleg-nenashev requested review from daniel-beck and a team July 3, 2019 11:47
@oleg-nenashev oleg-nenashev changed the title [WEBSITE-634] - Add Release Drafter configurationfor drafting Weekly release YAMLs [WEBSITE-634] - Add Release Drafter configuration for drafting Weekly release YAMLs Jul 3, 2019
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see the disclaimer added that this is a preliminary change log, but even without that change it is still a good improvement.

Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless.

Maybe we could just make https://jenkins.io/changelog/ redirect to https://github.com/jenkinsci/jenkins/releases and go all in! If we want to keep the stability voting system, perhaps it could be reimplemented as some sort of GitHub App widget embedded in the Markdown for the release (and it would make sense to extend it to plugin releases too).

@oleg-nenashev
Copy link
Member Author

Maybe we could just make https://jenkins.io/changelog/ redirect to https://github.com/jenkinsci/jenkins/releases and go all in!

I would prefer to not do it in the first iteration. Can be done later once we have all machinery in WEBSITE-634 in place

@varyvol
Copy link

varyvol commented Jul 4, 2019

@oleg-nenashev seems fine, but one question: why only the last example has an associated issue but not the other ones?

@oleg-nenashev
Copy link
Member Author

why only the last example has an associated issue but not the other ones?

It is how my test data is organized. Only one pull request has a fake issue ID for testing

Copy link

@varyvol varyvol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

@oleg-nenashev oleg-nenashev added on-hold This pull request depends on another event/release, and it cannot be merged right now ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback labels Jul 4, 2019
@oleg-nenashev
Copy link
Member Author

On hold, pending feedback from @daniel-beck

@oleg-nenashev
Copy link
Member Author

@daniel-beck gentle ping

Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to hurt, has a chance of making things easier for us, and as long as we don't advertise it to users 🤷‍♂

@oleg-nenashev
Copy link
Member Author

Thanks @daniel-beck . It will not be visible to users at all if we do not manually publish the releases
:shipit:

@oleg-nenashev oleg-nenashev merged commit 59cd469 into master Jul 18, 2019
@oleg-nenashev oleg-nenashev deleted the release-drafter branch July 18, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal on-hold This pull request depends on another event/release, and it cannot be merged right now ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback
Projects
None yet
7 participants