-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WEBSITE-634] - Add Release Drafter configuration for drafting Weekly release YAMLs #4097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love to see the disclaimer added that this is a preliminary change log, but even without that change it is still a good improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems harmless.
Maybe we could just make https://jenkins.io/changelog/ redirect to https://github.com/jenkinsci/jenkins/releases and go all in! If we want to keep the stability voting system, perhaps it could be reimplemented as some sort of GitHub App widget embedded in the Markdown for the release (and it would make sense to extend it to plugin releases too).
I would prefer to not do it in the first iteration. Can be done later once we have all machinery in WEBSITE-634 in place |
@oleg-nenashev seems fine, but one question: why only the last example has an associated issue but not the other ones? |
It is how my test data is organized. Only one pull request has a fake issue ID for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!
On hold, pending feedback from @daniel-beck |
@daniel-beck gentle ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to hurt, has a chance of making things easier for us, and as long as we don't advertise it to users 🤷♂
Thanks @daniel-beck . It will not be visible to users at all if we do not manually publish the releases |
This is a follow-up to the common issues with delayed weekly release changelogs. Neither @daniel-beck nor me commit to deliver changelogs on the weekends when Jenkins weekly gets usually released, and often there are significant delays between a release and availability of changelog on https://jenkins.io/changelog/ . In order to solve the issue, I suggest using Release Drafter which has been already successfully adopted in plugins (Documentation). See WEBSITE-634 for more context.
Sample changelog YAML generated in my test environment:
Considerations:
Proposed changelog entries
Submitter checklist
* Use the
Internal:
prefix if the change has no user-visible impact (API, test frameworks, etc.)Wishlist
rfe
, thenbug
and theninternal
Desired reviewers
@jenkinsci/core esp. @daniel-beck