Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JEP-236] [JENKINS-68570] Require Java 11 or newer #6083
[JEP-236] [JENKINS-68570] Require Java 11 or newer #6083
Changes from all commits
c303a78
43e1649
0c778b7
f74298d
c6eae4d
b5513d8
b692e12
6d74bcc
2a6ee0a
598fdc9
8736757
35d4930
139c17f
2b21238
2ca44e5
1a5d528
2c05146
2cc572b
d195bfb
1409081
74109dd
1d96882
a244461
e9d36a0
2596883
bf7ae88
fee0d26
42e7873
4c135ac
3f24e79
a51d145
cdc42e8
7d88c52
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just seems to be shuffled around from a profile, but while we are here and since it is related to Java 11: would it be possible to introduce a POM property in root
pom.xml
to enforce that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The versions in
core/pom.xml
andtest/pom.xml
could be deduplicated but the version inwar/pom.xml
cannot be deduplicated because it is in the form of aMANIFEST.MF
directive rather than command-line arguments. I am not sure the savings of 3 to 2 copies of the code is worth it.