Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace yui autocomplete with plain javascript in search-box #9231

Closed
wants to merge 4 commits into from
Closed

replace yui autocomplete with plain javascript in search-box #9231

wants to merge 4 commits into from

Conversation

mawinter69
Copy link
Contributor

The search box in the header is now implemented in plain javascript and no longer using yui autocomplete.

Minor adjustments to the styling and behaviour

  • box-shadow is now the same as the one for dropdowns
  • background of the suggestion list is the same as the background of the search input
  • search box is now instantly resized when one of the suggestions is selected
  • pressing enter when the input field is empty no longer forwards to the built-in node but does nothing

The jelly is not changed so the change is compatible with the header implementation in customizable-header plugin

Before:
image

After:
image

Testing done

Manual interactive testing

Proposed changelog entries

  • reimplement search-box frontend

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@mawinter69
replace yui autocomplete with plain javascript in sarch-box
47cc257 
The search box in the header is now implemented in plain javascript and
no longer using yui autocomplete.

Minor adjustments to the styling
- box-shadow is now the same as the one for dropdowns
- background of the suggestion list is the same as the background of the
  search input
@mawinter69
fix htmlunit error, styling
b3cdf64
@NotMyFault NotMyFault requested review from a team May 8, 2024 15:23
@NotMyFault NotMyFault added the web-ui The PR includes WebUI changes which may need special expertise label May 8, 2024
timja
timja reviewed May 8, 2024
View reviewed changes
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see also #7569

@yaroslavafenkin yaroslavafenkin added the needs-security-review Awaiting review by a security team member label May 14, 2024
@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label May 18, 2024
@github-actions GitHub Actions
Copy link

Please take a moment and address the merge conflicts of your pull request. Thanks!

@mawinter69
Copy link
Contributor Author

close in favor of #7569

@mawinter69 mawinter69 closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timja timja timja left review comments

Assignees
No one assigned
Labels
needs-security-review Awaiting review by a security team member unresolved-merge-conflict There is a merge conflict with the target branch. web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Milestone
No milestone
4 participants
@mawinter69 @timja @NotMyFault @yaroslavafenkin