Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential github action smells #9236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix potential github action smells #9236

wants to merge 2 commits into from
+8 −5

Conversation

ceddy4395
Copy link

@ceddy4395 ceddy4395 commented May 5, 2024 •
edited by MarkEWaite

Hey! 🙂
I want to contribute the following changes to your workflow:

  • Define permissions for workflows with external actions
  • Avoid starting new workflow whilst the previous one is still running
  • Avoid deploying jobs on forks

(These changes are part of a research Study at TU Delft looking at GitHub Action Smells. Find out more)

Testing done

None

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  4. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  5. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  6. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  7. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@ceddy4395
Fix gha smells:
df8eb1c 
- Define permissions for workflows with external actions
- Avoid starting new workflow whilst the previous one is still running
- Avoid deploying jobs on forks
@welcome Welcome
Copy link

welcome bot commented May 5, 2024

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@ceddy4395 ceddy4395 changed the title Fix gha smells: Fix potential github action smells May 5, 2024
@MarkEWaite MarkEWaite added the skip-changelog Should not be shown in the changelog label May 6, 2024
MarkEWaite
MarkEWaite reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question on the concurrency limiting change in the upload-release action. If an upload is interrupted, will the partial upload be discarded or retained?

The checks for repository are a positive change that I fully support.

.github/workflows/publish-release-artifact.yml Outdated Show resolved Hide resolved
@ceddy4395 @MarkEWaite
Revert adding concurrency
366d362 
Remove concurrency to avoid interrupting uploads.

Co-authored-by: Mark Waite <mark.earl.waite@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite Awaiting requested review from MarkEWaite

Assignees
No one assigned
Labels
skip-changelog Should not be shown in the changelog
Projects
None yet
Milestone
No milestone
2 participants
@ceddy4395 @MarkEWaite